Don't store a file for dynamically generated item. #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We try to detect where a item was define, sometime methods/objects are dynamically defined. When this is the case, we get back a file that contain `<string>` in it's name. When that's the case we store `None` instead. I'm wondering if we should store something else, as `None` also mean we were not able to find what the source was...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We try to detect where a item was define, sometime methods/objects are dynamically defined.
When this is the case, we get back a file that contain
<string>in it's name. When that's the case we storeNoneinstead.I'm wondering if we should store something else, as
Nonealso mean we were not able to find what the source was...