Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing code style suggestions from Carriage Return fix PR #618

Merged
merged 2 commits into from
Aug 15, 2024

Conversation

dalthviz
Copy link
Collaborator

Follow up for #607 as discussed at #607 (comment)

@dalthviz dalthviz added the task label Aug 12, 2024
@dalthviz dalthviz added this to the 5.6.0 milestone Aug 12, 2024
@dalthviz dalthviz self-assigned this Aug 12, 2024
@dalthviz dalthviz requested a review from ccordoba12 August 12, 2024 20:44
Copy link
Collaborator

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two tiny suggestions that I missed in my previous review, the rest looks good to me.

qtconsole/console_widget.py Outdated Show resolved Hide resolved
qtconsole/console_widget.py Outdated Show resolved Hide resolved
@dalthviz dalthviz requested a review from ccordoba12 August 15, 2024 19:10
Copy link
Collaborator

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dalthviz!

@ccordoba12 ccordoba12 merged commit 39cd91b into jupyter:main Aug 15, 2024
22 checks passed
@TheMatt2
Copy link
Contributor

TheMatt2 commented Sep 5, 2024

I am total on board with these changes. Thanks for taking care of this. I've been busy with other things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants