Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy & Paste objects #624

Merged
merged 6 commits into from
Dec 3, 2024
Merged

Copy & Paste objects #624

merged 6 commits into from
Dec 3, 2024

Conversation

arjxn-py
Copy link
Member

@arjxn-py arjxn-py commented Dec 2, 2024 •
edited
Loading

Addresses #391

Copy-Paste.mov

@arjxn-py arjxn-py added the enhancement New Feature or improvement label Dec 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024 •
edited
Loading

Integration tests report: appsharing.space

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024 •
edited
Loading

Preview PR at appsharing.space

martinRenou
martinRenou reviewed Dec 2, 2024
View reviewed changes
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! I just have a slight concern + a small suggestion, otherwise it's looking good

packages/base/src/commands.ts Show resolved Hide resolved
packages/base/src/commands.ts Outdated Show resolved Hide resolved
martinRenou
martinRenou approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@martinRenou martinRenou merged commit 7a2c3b6 into jupytercad:main Dec 3, 2024
10 checks passed
@martinRenou martinRenou mentioned this pull request Dec 3, 2024
Closed
@arjxn-py arjxn-py deleted the copy-paste branch December 31, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trungleduc trungleduc trungleduc left review comments

@martinRenou martinRenou martinRenou approved these changes

Assignees
No one assigned
Labels
enhancement New Feature or improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arjxn-py @trungleduc @martinRenou