Merge pull request #1741 from yuvipanda/binderhub-client-urlparams

Use URLSearchParams() to construct query strings
jupyterhub · Sep 21, 2023 · 1d57da1 · 1d57da1
2 parents 05f0755 + d220cba
commit 1d57da1
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/js/packages/binderhub-client/lib/index.js b/js/packages/binderhub-client/lib/index.js
@@ -25,11 +25,14 @@ export class BinderRepository {
    * Call the BinderHub API
    */
   fetch() {
-    let apiUrl = this.baseUrl + "build/" + this.providerSpec;
+    let apiUrl =  new URL(this.baseUrl + "build/" + this.providerSpec);
+    let params = new URLSearchParams();
     if (this.buildToken) {
-        apiUrl = apiUrl + `?build_token=${this.buildToken}`;
+        params.append('build_token', this.buildToken);
     }
 
+    apiUrl.search = params.toString();
+
     this.eventSource = new EventSource(apiUrl);
     this.eventSource.onerror = (err) => {
       console.error("Failed to construct event stream", err);