Clarify how build endpoint URL is constructed

jupyterhub · Oct 3, 2023 · c2cf3d5 · c2cf3d5
1 parent 17a3bf9
commit c2cf3d5
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/binderhub/static/js/index.js b/binderhub/static/js/index.js
@@ -160,7 +160,9 @@ function build(providerSpec, log, fitAddon, path, pathType) {
   $('.on-build').removeClass('hidden');
 
   const buildToken = $("#build-token").data('token');
-  // If BASE_URL is absolute, use that. Else, resolve it relative to current URL
+  // If BASE_URL is absolute, use that as the base for build endpoint URL.
+  // Else, first resolve BASE_URL relative to current URL, then use *that* as the
+  // base for the build endpoint url.
   const buildEndpointUrl = new URL("build", new URL(BASE_URL, window.location.href));
   const image = new BinderRepository(providerSpec, buildEndpointUrl, buildToken);