Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mercurial repo provider #1162

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

paugier
Copy link

@paugier paugier commented Oct 5, 2020

Note: This PR depends on an unreleased version of repo2docker (jupyterhub/repo2docker#950)

It implements a Mercurial repo provider (and therefore fixes #1148).

I tried to copy the GitRepoProvider but I'm not sure about how are used the different methods (and I don't know Javascript!).

@gracinet You may be interested to check what I did.

@welcome
Copy link

welcome bot commented Oct 5, 2020

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@paugier paugier force-pushed the add-MercurialRepoProvider branch 2 times, most recently from f3a67a4 to 87bb67a Compare October 6, 2020 08:42
@gracinet
Copy link

gracinet commented Oct 6, 2020

I'm not familiar with the Jupyter context, but the Mercurial side of it looks fine to me.

@paugier paugier force-pushed the add-MercurialRepoProvider branch 2 times, most recently from 68b0500 to eb4890e Compare October 6, 2020 20:55
@paugier paugier marked this pull request as draft October 7, 2020 13:02
@paugier paugier changed the title WIP: Add mercurial repo provider Add mercurial repo provider Oct 7, 2020
@paugier paugier marked this pull request as ready for review October 7, 2020 13:03
@paugier
Copy link
Author

paugier commented Nov 17, 2020

It would be great if someone can have a look at this PR?

@consideRatio consideRatio added code:html/js/css html/js/css changes. code:python Python changes. new labels Oct 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code:html/js/css html/js/css changes. code:python Python changes. new
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Mercurial repositories?
3 participants