Add all c.BinderHub.* properties used in chart to Values.yaml
#1603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
except for `buildDockerConfig` which is being dealt with seperately.
```
$ git grep Values\\.config\\. -- helm-chart/
helm-chart/binderhub/templates/_helpers.tpl:{{- if .Values.config.BinderHub.buildDockerConfig }}
helm-chart/binderhub/templates/_helpers.tpl:{{- $dockerConfig := merge $dockerConfig .Values.config.BinderHub.buildDockerConfig }}
helm-chart/binderhub/templates/container-builder/daemonset.yaml: nodeSelector: {{ .Values.config.BinderHub.build_node_selector | default dict | toJson }}
helm-chart/binderhub/templates/deployment.yaml: {{- if .Values.config.BinderHub.use_registry }}
helm-chart/binderhub/templates/deployment.yaml: {{- if .Values.config.BinderHub.use_registry }}
helm-chart/binderhub/templates/deployment.yaml: {{- if .Values.config.BinderHub.auth_enabled }}
helm-chart/binderhub/templates/deployment.yaml: value: {{ (print (.Values.config.BinderHub.hub_url_local | default .Values.config.BinderHub.hub_url | trimSuffix "/") "/hub/api/") }}
helm-chart/binderhub/templates/deployment.yaml: path: {{ .Values.config.BinderHub.base_url | default "/" }}versions
helm-chart/binderhub/templates/deployment.yaml: path: {{ .Values.config.BinderHub.base_url | default "/" }}versions
helm-chart/binderhub/templates/image-cleaner.yaml: nodeSelector: {{ .Values.config.BinderHub.build_node_selector | toJson }}
helm-chart/binderhub/templates/secret.yaml:{{- if or .Values.config.BinderHub.use_registry .Values.config.BinderHub.buildDockerConfig }}
```
This helps reduce the "hidden" configuration in the Helm Chart.
consideRatio
pushed a commit
to jupyterhub/helm-chart
that referenced
this pull request
Dec 29, 2022
jupyterhub/binderhub#1603 Merge pull request #1603 from manics/helmchart-config-defaults
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #1597
Adds all
c.BinderHub.*properties used in chart to Values.yaml for visibility, except forbuildDockerConfigwhich will be dealt with separately.This helps reduce the "hidden" configuration in the Helm Chart.