Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dynamic registry tokens, add wrapper for working with registry microservice #1637

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

manics
Copy link
Member

@manics manics commented Feb 21, 2023

This is a companion for jupyterhub/repo2docker#1245 that allows dynamic credentials t be used for pushing to a registry. This is required for e.g. ECR where the token used to login to the reigistry expires.

This also implements the non-vendor specific parts of
#1623

Closes #705

You can see an example implementation of the microservice side in
https://github.com/manics/binderhub-container-registry-helper
This is working with AWS ECR using an IRSA role for the microservice.

It's written in Go as I wanted to learn it, but if we choose to pursue this rewriting it in Python (or Javascript, or any other language) shouldn't be too difficult.

@manics manics changed the title For discussion: Support dynamic registry tokens, add wrapper for working with registry microservice WIP: Support dynamic registry tokens, add wrapper for working with registry microservice Feb 21, 2023
@manics manics mentioned this pull request May 3, 2023
5 tasks
@manics manics force-pushed the registry-dynamic-token branch 2 times, most recently from 06f105e to c38e5f3 Compare December 15, 2023 21:37
@manics manics force-pushed the registry-dynamic-token branch 2 times, most recently from 0b1eba8 to 53fe226 Compare March 6, 2024 22:18
@manics manics marked this pull request as ready for review March 12, 2024 23:42
@manics manics closed this Jul 21, 2024
@manics manics reopened this Jul 21, 2024
@manics manics requested a review from yuvipanda July 21, 2024 08:15
@manics manics changed the title WIP: Support dynamic registry tokens, add wrapper for working with registry microservice Support dynamic registry tokens, add wrapper for working with registry microservice Jul 21, 2024
@manics
Copy link
Member Author

manics commented Sep 19, 2024

Anyone else have thoughts on this? @stevejpurves is interested in using it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS ECR registry for BinderHub deployment
1 participant