Add BuildExecutor.repo2docker_extra_args config
#1766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Very helpful for a specific binderhub instance to customize how images are built. Off the top of my head, two useful things would be to pass `--repo-dir` (so you can have this work with a persistent home directory but still get access to the files in the image), and `--base-image` (so an install can use a different base image than rep2docker default). As it's a simple passthrough, I've added a unit test only (no integration test). Fixes jupyterhub#1765
|
Failures are unrelated I think |
manics
approved these changes
Oct 7, 2023
There was a problem hiding this comment.
My original thinking behind the get_r2d_cmd_options() function was that you could easily override it by subclassing BuildExecutor.
Adding a new parameter seems fine though, especially if this means we can say we won't add traitlets to pass other repo2docker arguments, and instead refer people to this new property instead.
|
Lgtm! I tweaked the title to "Add |
consideRatio
changed the title
repo2docker_extra_args config
consideRatio
changed the title
repo2docker_extra_args configBuildExecutor.repo2docker_extra_args config
consideRatio
pushed a commit
to jupyterhub/helm-chart
that referenced
this pull request
Oct 9, 2023
jupyterhub/binderhub#1766 Merge pull request #1766 from yuvipanda/extra-args
This was referenced Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very helpful for a specific binderhub instance to customize how images are built. Off the top of my head, two useful things would be to pass
--repo-dir(so you can have this work with a persistent home directory but still get access to the files in the image), and--base-image(so an install can use a different base image than rep2docker default).As it's a simple passthrough, I've added a unit test only (no integration test).
Fixes #1765