Implement support for image pull secrets for build pod #1806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This new KubernetesBuildExecutor specific option allows to set a list of image pull secret so that the build pod can also access private registries to retrieve the image it uses.
minrk
approved these changes
Dec 15, 2023
consideRatio
pushed a commit
to jupyterhub/helm-chart
that referenced
this pull request
Dec 15, 2023
jupyterhub/binderhub#1806 Merge pull request #1806 from sgaist/build_image_pull_secrets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge request implements the configuration option required for the build pod to also be able to use images from private registries.
The other components that are deployed through helm already have that support but the build pod being generated does not.
Fixes #1805