Update message about repo not allowed to launch #1868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @consideRatio |
consideRatio
pushed a commit
to jupyterhub/helm-chart
that referenced
this pull request
Jul 9, 2024
jupyterhub/binderhub#1868 Merge pull request #1868 from consideRatio/pr/update-msg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are checking
is_banned(really a check if the repo is allowed or not), and if its not allowed we write a message saying "has been temporarily disabled" - but I think its incorrect to include "temporarily" here as we may work against a check of allowed repositories and not just bans (temporary?).