Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node update part 2 #2105

Merged
merged 2 commits into from
Jan 25, 2022
Merged

Node update part 2 #2105

merged 2 commits into from
Jan 25, 2022

Conversation

minrk
Copy link
Member

@minrk minrk commented Jan 25, 2022 •
edited
Loading

follow-up to #2102 (PR 2/4 probably)

  • old core pool is drained, so can be removed
  • set initial_node_count on new pools, otherwise they won't get any nodes to start until an autoscale event triggers
  • ignore initial_node_count in lifecycle hook, since it will change with autoscaling, and changing it triggers destroy & recreate

Will probably delete old user pool tonight or tomorrow, after cordoning and draining to the new pool

minrk added 2 commits January 25, 2022 13:35
@minrk
set initial node count on new pools
451a99e 
and ignore subsequent changes in lifecycle hooks to avoid destroying and recreating on autoscale
@minrk
terraform: remove empty core pool
d25ef1c 
user pool will take longer to empty - perhaps tomorrow
@minrk minrk merged commit bdd4e0e into jupyterhub:master Jan 25, 2022
@minrk minrk deleted the node-upgrade-part-2 branch January 25, 2022 12:41
@minrk minrk mentioned this pull request Jan 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@minrk