make sure to catch async errors, too

jupyterhub · Aug 29, 2024 · 010c288 · 010c288
1 parent ae48b33
commit 010c288
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/oauthenticator/oauth2.py b/oauthenticator/oauth2.py
@@ -1184,12 +1184,12 @@ async def _call_modify_auth_state_hook(self, auth_state):
         """Call the modify_auth_state_hook"""
         try:
             auth_state = self.modify_auth_state_hook(self, auth_state)
+            if isawaitable(auth_state):
+                auth_state = await auth_state
         except Exception as e:
             # let hook errors raise, nothing in auth should suppress errors
             self.log.error(f"Error in modify_auth_state_hook: {e}")
             raise
-        if isawaitable(auth_state):
-            auth_state = await auth_state
         return auth_state
 
     async def authenticate(self, handler, data=None, **kwargs):