Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement oauthenticator.OAuthenticator.refresh_user method #579

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

feat: Implement oauthenticator.OAuthenticator.refresh_user method #579

wants to merge 12 commits into from
+225 −28

Commits on Sep 2, 2024

  1. feat: Implement generic refresh_user() method, not tested

    @GeorgianaElena
    Julien LE MÉNER authored and GeorgianaElena committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    803dc71 View commit details
    Browse the repository at this point in the history

  2. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci @GeorgianaElena
    pre-commit-ci[bot] authored and GeorgianaElena committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    31f8cbb View commit details
    Browse the repository at this point in the history

  3. Add missing kwargs for test, fix format

    @GeorgianaElena
    Julien LE MÉNER authored and GeorgianaElena committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    2c5b30d View commit details
    Browse the repository at this point in the history

  4. Refactor and rm the env var support

    @GeorgianaElena
    GeorgianaElena committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    4e7943b View commit details
    Browse the repository at this point in the history

  5. Get the conditional right

    @GeorgianaElena
    GeorgianaElena committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    c0fbad4 View commit details
    Browse the repository at this point in the history

  6. Add comment link to rfc

    @GeorgianaElena
    GeorgianaElena committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    61f1b03 View commit details
    Browse the repository at this point in the history

  7. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    3ef16df View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2024

  1. Merge with main

    @minrk
    minrk committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    4214127 View commit details
    Browse the repository at this point in the history

  2. remove duplicate auth expiration config 

    refresh_user should always refresh auth,
JupyterHub config already exists to determine expiration
    @minrk
    minrk committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    6156c93 View commit details
    Browse the repository at this point in the history

  3. more cases for refresh_user 

    - do not refresh if auth_state is disabled (would force re-login every 5 minutes in default config)
- always refresh if refresh_token is defined
- if refresh_token not available, only check validity of access_token and refresh associated user info
    @minrk
    minrk committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    3d37ff8 View commit details
    Browse the repository at this point in the history

  4. only refresh expired access tokens

    @minrk
    minrk committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    a8fe500 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2024

  1. more specific error handling for failure to refresh auth 

    only consider HTTP 4XX expired auth
    @minrk
    minrk committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    1900167 View commit details
    Browse the repository at this point in the history