Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CILogon] Add idp config allowed_domains_claim for use with allowed_domains #702

Merged

Conversation

consideRatio
Copy link
Member

@consideRatio consideRatio commented Nov 22, 2023

An opt-in non-breaking step along the way to address #547. The issue is perhaps best solved long term by doing the breaking change of letting allowed_domains_claim default to "email".

Change summary

  • (unrelated bugfix) Makes allowed_domains no longer be case sensitive, and adds test case
  • Adds allowed_domains_claim config (docs updated, schema updated, a test is added)
  • Makes the specified claim able to directly specify a domain name, and not only indirectly via an email like string.

@consideRatio consideRatio merged commit c6e5b0c into jupyterhub:main Nov 23, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants