Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CILogon] Fix missing schema entry for default under allowed_idps #704

Merged
merged 1 commit into from
Nov 27, 2023
Merged

[CILogon] Fix missing schema entry for default under allowed_idps #704

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions oauthenticator/schemas/cilogon-schema.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ properties:
type: string
allowed_domains_claim:
type: string
default:
type: boolean
username_derivation:
type: object
additionalProperties: false
Expand Down
1 change: 1 addition & 0 deletions oauthenticator/tests/test_cilogon.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -636,6 +636,7 @@ async def test_allowed_idps_username_derivation_actions(cilogon_client):
c.CILogonOAuthenticator.allow_all = True
c.CILogonOAuthenticator.allowed_idps = {
'https://strip-idp-domain.example.com/login/oauth/authorize': {
'default': True,
'username_derivation': {
'username_claim': 'email',
'action': 'strip_idp_domain',
Expand Down