Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changelog for v16.3.1 #744

Merged
merged 3 commits into from
Jun 11, 2024
Merged

Add changelog for v16.3.1 #744

merged 3 commits into from
Jun 11, 2024

Conversation

yuvipanda
Copy link
Collaborator

While trying to get a fix out for GHSA-gprj-3p75-f996, instead of making a backported release, I released from main. This was a mistake, but not a costly one. As I start doing more releases, I'll get better.

I could not get github-activity to work, so I manually constructed the changelog to the best of my ability. I reported the issue upstream in executablebooks/github-activity#96.

While trying to get a fix out for GHSA-gprj-3p75-f996,
instead of making a backported release, I released from
main. This was a mistake, but not a costly one. As I start doing
more releases, I'll get better.

I could not get github-activity to work, so I manually
constructed the changelog to the best of my ability. I reported
the issue upstream in executablebooks/github-activity#96.
Excessive ref documentation like this goes out of date (the
documentation link is broken, and the JupyterHub link is also out of date
as newer versions comes out). I don't think we should add those inside
code.
@yuvipanda yuvipanda requested a review from minrk June 11, 2024 23:20
@yuvipanda
Copy link
Collaborator Author

Given that I made the release already, I'll say 'mea culpa' and merge this myself, since I want people to be able to see a changelog when they look. I'll get better at making releases, I swear.

@yuvipanda yuvipanda merged commit 10adfa9 into jupyterhub:main Jun 11, 2024
11 checks passed
@minrk
Copy link
Member

minrk commented Jun 12, 2024

Sorry for the trouble, and thanks for making the release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants