Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Google] Remove redundant service credential checks #774

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

jrdnbradford
Copy link
Contributor

This removes some redundancy in the service credential checks for Google.

According to their docs, the valid attribute returns True if token exists and isn't expired, so we can switch out those two checks for one.

Further, the _get_service_credentials() method already checks whether user_email_domain is in self._service_credentials so this check isn't also needed in _is_token_valid().

@minrk minrk merged commit 9031e4c into jupyterhub:main Nov 11, 2024
11 checks passed
@jrdnbradford jrdnbradford deleted the remove-redundancies-google branch November 11, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants