[Google] Remove redundant service credential checks #774
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes some redundancy in the service credential checks for Google.
According to their docs, the
valid
attribute returnsTrue
iftoken
exists and isn'texpired
, so we can switch out those two checks for one.Further, the
_get_service_credentials()
method already checks whetheruser_email_domain
is inself._service_credentials
so this check isn't also needed in_is_token_valid()
.