New domain for Edmond MPG repository #1321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting your first pull request! You are awesome! 🤗 |
manics
reviewed
Nov 14, 2023
| { | ||
| "description": "The Research Data Repository for the Max Planck Society.", | ||
| "full_name": "Edmond - Research Data Repository for the Max Planck Society", | ||
| "id": 1796, |
There was a problem hiding this comment.
Is this a reference to an external id, or is it managed by repo2docker?
There was a problem hiding this comment.
Do you mean the "1796"? I just added +1 to the last ID in the list, as everyone did before. So this shouldn't be managed by repo2docker
|
Congrats on your first merged pull request in this project! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently moved our Dataverse repository "Edmond" from https://edmond.mpdl.mpg.de to https://edmond.mpg.de.
Currently, we still have old DOIs registered with the old URL, new DOIs are registered with the new URL. There are of course redirects, but as the dataverse.py script directly compares the URL from the DOI with the list of dataverse installations, DOIs with the new URL do not work with MyBinder anymore.
This pull requests adds a second entry for "Edmond" with the new domain, so both types of URLs should work. This is just a temporary solution. We are planning to migrate the old DOIs to the new domain. As soon as this process is finished, the entry for the old domain could be deleted (we will provide another pull request then).
In the meantime, we'd appreciate if you allow us two entries. Thank you.