-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dockerfile: bump alpine from 3.17 to 3.19 and Python 3.10 to 3.11 #1332
Conversation
What are the benefits of using a virtualenv inside the image? |
@manics it is mandatory now, it errors out if you don't use one (https://peps.python.org/pep-0668/). You can see the full config in https://github.com/jupyterhub/repo2docker/actions/runs/7768480733/job/21186449405
|
Brings us to latest alpine, and to a newer python
The use of `ENV key value` is an old alternative syntax still around for backward compatibility, but may be removed according to https://docs.docker.com/reference/dockerfile/#env.
Merging this resolves repo2docker-action jupyterhub/repo2docker-action#113. I pushed commits to:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If tests pass, this LGTM.
I marked this as breaking to highlight it as a possible breaking change for users of the image |
Brings us to latest alpine, and to a newer python