Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Python 3.12 #1347

Merged
merged 1 commit into from
May 29, 2024
Merged

add Python 3.12 #1347

merged 1 commit into from
May 29, 2024

Conversation

minrk
Copy link
Member

@minrk minrk commented May 21, 2024

just ran python3 repo2docker/buildpacks/conda/freeze.py 3.12 and added 3.12 to the refreeze list

closes #1225

@minrk minrk changed the title add environment for 3.12 add Python 3.12 May 21, 2024
@manics
Copy link
Member

manics commented May 21, 2024

The latest version of requests breaks docker-py, causing all tests to fail:
docker/docker-py#3256

@minrk
Copy link
Member Author

minrk commented May 21, 2024

Not in a rush, let's let that settle for a bit before pinning down requests to avoid a security patch, though this particular case doesn't affect repo2docker users since it only applies to multiple requests to the same host where the value of verify changes from False to True, which is a sequence that can't happen within a run of repo2docker, I think.

@manics
Copy link
Member

manics commented May 24, 2024

tests/venv/binder-dir and tests/venv/start/postBuild are failing for an unrelated reason (also failing on main):
KeyError: 'The Python module ipyleaflet is not a valid nbextension, it is missing the _jupyter_nbextension_paths() method.'

@minrk
Copy link
Member Author

minrk commented May 27, 2024

ipyleaflet 0.19 refactored some things, and ipyleaflet is no longer a valid extension package (jupyter_leaflet is). I'm not sure if this is intentional, but this command is still in their installation docs, so I'm guessing it is a mistake.

This nbextension step has not been required since notebook 5.3, so these tests (especially postBuild) aren't really testing that they do anything.

@manics manics closed this May 29, 2024
@manics manics reopened this May 29, 2024
@manics manics merged commit 6014649 into jupyterhub:main May 29, 2024
29 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python 3.11 and beyond
3 participants