Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update postBuild tests without ipyleaflet #1348

Merged
merged 4 commits into from
May 27, 2024

Conversation

manics
Copy link
Member

@manics manics commented May 26, 2024

tests/venv/binder-dir/binder and tests/venv/start/postBuild are currently failing with ipyleaflet 0.19:

KeyError: 'The Python module ipyleaflet is not a valid nbextension, it is missing the `_jupyter_nbextension_paths()` method.'

@manics manics added the ci label May 26, 2024
@manics
Copy link
Member Author

manics commented May 27, 2024

I've created an issue for the remaining failing test (Julia) #1349

@minrk minrk changed the title tests: pin ipyleaflet<0.19 to get tests passing update postBuild tests without ipyleaflet May 27, 2024
@minrk minrk merged commit a4049fd into jupyterhub:main May 27, 2024
17 of 18 checks passed
@manics manics deleted the ipyleaflet-pin-tests branch May 27, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants