Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exclude defaults channel by default #1365

Merged
merged 2 commits into from
Aug 19, 2024
Merged

Conversation

minrk
Copy link
Member

@minrk minrk commented Aug 16, 2024

make sure we're always using conda-forge by default

it's unlikely any packages came from defaults for users in some years (due to channel priority, this would only happen for packages not on conda-forge, and would often result in a broken env anyway), but this ensures defaults channel is opt-in, as it should be for the Anaconda ToS.

make sure we're always using conda-forge

it's unlikely any packages came from defaults for users (will only happen for packages not on conda-forge, and would often result in a broken env anyway),
but this ensures defaults channel is opt-in.
@rgaiacs
Copy link

rgaiacs commented Aug 16, 2024

What do you think of repo2docker to fail if user's provided environment.yml uses default Anaconda repository? Maybe have an option for this behaviour for the special case of mybinder.org.

@minrk
Copy link
Member Author

minrk commented Aug 16, 2024

I don't believe it is up to us. We could block egress to repo.anaconda.com, I suppose, but I don't think we need to. A user may install from the defaults channel and use it on mybinder.org if their use is permitted. mybinder.org doesn't enter into it, just like they can do on any cloud provider.

@rgaiacs
Copy link

rgaiacs commented Aug 16, 2024

Looks good to me.

@minrk
Copy link
Member Author

minrk commented Aug 16, 2024

Because we don't set strict channel priority, it is possible for a downgraded solve to pick from defaults in situations where packages are being downgraded, or version requirements are unsatisfiable on conda-forge. This should still be very unlikely.

This also removes unnecessary repodata requests for the defaults channel that's going unused and might be blocked by firewalls.

@rgaiacs
Copy link

rgaiacs commented Aug 19, 2024

Renato Alves mentioned in the German RSE list that

At the moment 3 channels are firewall blocked across all EMBL sites: defaults, main and r. All these channels are under the same terms of service.

@minrk can we update this PR to include all three channels? defaults, main and r.

@minrk
Copy link
Member Author

minrk commented Aug 19, 2024

@rgaiacs I'm not sure what you mean. We had 2 channels (conda-forge, defaults), now there is 1 (conda-forge). main and r are not in the available channels list in config.

@rgaiacs
Copy link

rgaiacs commented Aug 19, 2024

@minrk looks good. I need more coffee. :-D

@minrk minrk merged commit a61ec54 into jupyterhub:main Aug 19, 2024
18 checks passed
@minrk minrk deleted the disallow-defaults branch August 19, 2024 08:51
@minrk
Copy link
Member Author

minrk commented Aug 19, 2024

Because this removes an unused repodata request for the defaults channel, this should speed up installs ever so slightly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants