-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
exclude defaults channel by default #1365
Conversation
make sure we're always using conda-forge it's unlikely any packages came from defaults for users (will only happen for packages not on conda-forge, and would often result in a broken env anyway), but this ensures defaults channel is opt-in.
What do you think of repo2docker to fail if user's provided |
I don't believe it is up to us. We could block egress to repo.anaconda.com, I suppose, but I don't think we need to. A user may install from the defaults channel and use it on mybinder.org if their use is permitted. mybinder.org doesn't enter into it, just like they can do on any cloud provider. |
Looks good to me. |
Because we don't set strict channel priority, it is possible for a downgraded solve to pick from defaults in situations where packages are being downgraded, or version requirements are unsatisfiable on conda-forge. This should still be very unlikely. This also removes unnecessary repodata requests for the |
Renato Alves mentioned in the German RSE list that
@minrk can we update this PR to include all three channels? |
@rgaiacs I'm not sure what you mean. We had 2 channels ( |
@minrk looks good. I need more coffee. :-D |
Because this removes an unused repodata request for the |
make sure we're always using conda-forge by default
it's unlikely any packages came from defaults for users in some years (due to channel priority, this would only happen for packages not on conda-forge, and would often result in a broken env anyway), but this ensures defaults channel is opt-in, as it should be for the Anaconda ToS.