build: migrate from setup.py to pyproject.toml #1458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
rgaiacs
requested changes
Aug 25, 2025
| [project] | ||
| name = "jupyter-repo2docker" | ||
| dynamic = ["version"] | ||
| description = "Repo2docker: Turn code repositories into Jupyter enabled Docker Images" |
There was a problem hiding this comment.
Replace Repo2docker with repo2docker
|
|
||
|
|
||
| [tool.setuptools_scm] | ||
| # 这个配置会让 setuptools-scm 自动创建一个 my_awesome_project/_version.py 文件， |
| @@ -0,0 +1,18 @@ | |||
| import tomllib | |||
There was a problem hiding this comment.
tomllib requires Python 3.11. This might be the reason that all tests are failing.
| try: | ||
| with open("pyproject.toml", "rb") as f: | ||
| tomllib.load(f) | ||
| print("✅ TOML语法正确") |
There was a problem hiding this comment.
Can the Chinese text be translated into English?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves dependency management, IDE support, and aligns with current Python packaging standards.