Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add LogStore to retain build logs, and a S3LogStore implementation #967

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

Add LogStore to retain build logs, and a S3LogStore implementation #967

wants to merge 12 commits into from
+228 −2

Commits on Oct 3, 2020

  1. s3 logs prototype

    @manics
    manics committed Oct 3, 2020
    Configuration menu
    Copy the full SHA
    e2633b0 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2020

  1. Remove ANSI terminal escapes from logs

    @manics
    manics committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    fff010b View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2020

  1. Move S3 log upload into a Configurable class

    @manics
    manics committed Oct 9, 2020
    Configuration menu
    Copy the full SHA
    83d0f28 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2020

  1. Remove S3LogStore.close return URL 

    This adds unnecessary complexity since it depends on the S3 server, so rely on the user to know how to get the URL
    @manics
    manics committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    52c732b View commit details
    Browse the repository at this point in the history

  2. Add mock unittest for S3LogStore 

    Add boto3 to test dependencies
    @manics
    manics committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    d69ca94 View commit details
    Browse the repository at this point in the history

  3. S3LogStore set charset=utf-8

    @manics
    manics committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    c3991e8 View commit details
    Browse the repository at this point in the history

  4. S3LogStore add metadata

    @manics
    manics committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    a028dc2 View commit details
    Browse the repository at this point in the history

  5. S3LogStore fix logname

    @manics
    manics committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    6d54148 View commit details
    Browse the repository at this point in the history

  6. S3LogStore only log if non-empty, default key repo2docker.log (no i… 

    …mage name).
    @manics
    manics committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    792bbe0 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2020

  1. logstore: remove ACL 

    AWS S3 ACLs are legacy: https://aws.amazon.com/blogs/security/iam-policies-and-bucket-policies-and-acls-oh-my-controlling-access-to-s3-resources/
    @manics
    manics committed Oct 16, 2020
    Configuration menu
    Copy the full SHA
    cd90863 View commit details
    Browse the repository at this point in the history

  2. Move all log config into S3LogStore 

    repo2docker knows nothing about the logstore other than it should copy the Docker build logs to it
    @manics
    manics committed Oct 16, 2020
    Configuration menu
    Copy the full SHA
    0d28357 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2021

  1. Merge remote-tracking branch 'origin/master' into s3logs

    @manics
    manics committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    8cadb5b View commit details
    Browse the repository at this point in the history