-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Notebook, JupyterLab, Jupyter Resource Usage #928
Conversation
Thank you @jtpio! This won't be a breaking change as things aren't automatically upgraded, this is just for new installations anyhow. With that in mind I'm thinking this PR should be merged before ASAP and before 1.0.0 release. |
I see integration tests are failing because a call to a binary no longer around. But this test will be run with new and old versions of software installed in the user environment, because during an upgrade test we install with the previous version first and then install again with a new version, where the user environment isn't updated. So fixing this test failure must be done in a way supporting either binary name I think, or skipping it if the new binary isn't available - that is also fine in my mind. |
Ah that's good news! Also this change might need a new release of |
@jtpio we could relax this test I think, and just go for |
for more information, see https://pre-commit.ci
I opened jupyterhub/nbgitpuller#315 about this |
Nice thanks!
Checking first if the tests pass when using the new Actually even with |
Question: should users still be able to access the classic notebook UI? If yes:
|
Since this is for new installs etc, I suggest we make it not come with more stuff. I'm prefer seeing tljh install as little as possible though to let the admins decide from a relatively clean slate if they install more things etc. I think for now, lets go with this. |
Update Jupyter Notebook, JupyterLab and Jupyter Resource Usage to the latest major releases:
notebook
: https://jupyter-notebook.readthedocs.io/en/stable/changelog.htmljupyterlab
: https://jupyterlab.readthedocs.io/en/latest/getting_started/changelog.html#v4-0jupyter-resource-usage
: https://github.com/jupyter-server/jupyter-resource-usage/releases/tag/v1.0.0nbgitpuller
release: Add changelog for 1.2.0 nbgitpuller#315