tests: fix to catch test failure earlier when they really happen #975
Conversation
| assert await u.ensure_server_simulate(timeout=60, spawn_refresh_time=5) | ||
| assert await u.start_kernel() | ||
| assert await u.assert_code_output("5 * 4", "20", 5, 5) |
There was a problem hiding this comment.
Can return False when failing, so we should error early if that happens.
consideRatio
force-pushed
the
pr/fix-tests
branch
from
bc4f4b9
to
26ac117
Compare
|
@minrk I've concluded that when we upgrade from 0.2.0, the user environment will be old in general, and our tests with jupyterhub 4.1+ fails when hubtraf tries to start a kernel with a request to The version in the user env for server components are |
consideRatio
force-pushed
the
pr/fix-tests
branch
from
26ac117
to
ddede3a
Compare
|
Not expected, but since hubtraf is emulating a browser, it might not be doing everything browsers do (in particular, the valid XSRF token changes over time, and it may be caching an old value). Does it only happen with the oldest versions, not newer ones? Having a look now. |
|
Found it: jupyterhub/jupyterhub#4771 I can make 4.1.5 |
|
Wieeeee nice @minrk!! |
|
testing here with the 4.x branch, then I'll release 4.1.5: jupyterhub/jupyterhub#4773 |
|
Unrelated other failure - success i think! |
consideRatio
force-pushed
the
pr/fix-tests
branch
from
e6f1bf4
to
8fd41cc
Compare
consideRatio
changed the title
|
The previously broken 0.2.0 upgrade tests is no longer broken - thank you @minrk!! |
Just something observed when trying to resolve #974, which is fixed by jupyterhub 4.1.5 release and work in #962 by @jrdnbradford.