Update kubespawner ldapauthenticator #3562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minrk
reviewed
Oct 30, 2024
| jupyterhub-ltiauthenticator!=1.3.0 | ||
| jupyterhub-nativeauthenticator | ||
| jupyterhub-tmpauthenticator | ||
| oauthenticator[googlegroups,mediawiki] | ||
|
|
||
| ## Kubernetes spawner | ||
| jupyterhub-kubespawner==7.0.0b3 | ||
| jupyterhub-kubespawner>=7.0.0 |
There was a problem hiding this comment.
Suggested change
| jupyterhub-kubespawner>=7.0.0 | |
| jupyterhub-kubespawner==7.* |
There was a problem hiding this comment.
maybe keep the major pin on kubespawner?
There was a problem hiding this comment.
I figure we should either not have pins or systemticallcy pin major versions, fine with either. Do you see a reason to pin just kubespawner Min?
There was a problem hiding this comment.
I'm fine removing the pins. It's all pinned in requirements.txt, anyway.
kubespawner is special in that much of the chart itself is deeply tied to KubeSpawner in many ways. That's not really true of any package other than kubespawner and jupyterhub, so it doesn't seem odd to me to have special treatment of these two packages in that way.
I'm happy with this PR as-is, then.
consideRatio
pushed a commit
to jupyterhub/helm-chart
that referenced
this pull request
Oct 31, 2024
jupyterhub/zero-to-jupyterhub-k8s#3562 Merge pull request #3562 from manics/update-requirements.in
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should bring in kubespawner 7.0.0 and ldapauthenticator 2.0.1