Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GitHub hosted Ubuntu arm64 runners instead of CircleCI #3605

Merged
merged 4 commits into from
Jan 19, 2025

Conversation

manics
Copy link
Member

@manics manics commented Jan 16, 2025

https://github.blog/changelog/2025-01-16-linux-arm64-hosted-runners-now-available-for-free-in-public-repositories-public-preview/

This is on top of #3604

Currently there are some bugs in the runner image:

This results in helm attempting to create a config file n a location it doesn't have access to. We could fix the environment variable XDG_CONFIG_HOME, but let's see if it's fixed upstream.

If we want to merge this we'll need to disable the CircleCI check which is now failing since I've deleted .circleci/config.yml

@consideRatio
Copy link
Member

Oooooh nice fix transitioning from ancient minica image -> openssl image!!

certificate is valid for localhost, pebblepebble.defaultpebble.default.svcpebble.default.svc.cluster.local, not pebble" 

Seems like pebble and pebble.default etc was merged into a single string unintentionally.

@manics
Copy link
Member Author

manics commented Jan 18, 2025

Done in jupyterhub/pebble-helm-chart@aa6fc2b

@consideRatio
Copy link
Member

GitHub pages cache seems to serve the latest stuff already, we should be good to go here without using your fork again!

helm show chart --repo=https://hub.jupyter.org/helm-chart/ pebble | yq e '.version' -
1.3.0

Copy link
Member

@consideRatio consideRatio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to bed, but this looks great assuming tests pass after going back to using the pebble 1.3.0 version with you fix!

@manics manics marked this pull request as ready for review January 19, 2025 14:35
@manics
Copy link
Member Author

manics commented Jan 19, 2025

Green!

@manics manics merged commit 300a7e3 into jupyterhub:main Jan 19, 2025
13 checks passed
@manics manics deleted the ubuntu-arm branch January 19, 2025 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants