Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure internal classes used for style :host(.<class>) are not overridden by className #117

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

fcollonval
Copy link
Member

@fcollonval fcollonval commented Jul 12, 2024

When using the treeview in JupyterLab, we saw that some tree item were not getting the expected nested class that is handled within the component.

This solves it as well as potential similar issues on other components.

@fcollonval fcollonval added the bug Something isn't working label Jul 12, 2024
Copy link

Binder 👈 Launch a Binder on branch jupyterlab-contrib/jupyter-ui-toolkit/fix/tree-item-class

@fcollonval fcollonval merged commit da28333 into main Jul 12, 2024
11 of 12 checks passed
@fcollonval fcollonval deleted the fix/tree-item-class branch July 12, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant