Update codemirror-vim to 6.2.1 and jupyterlab to 4.2.0
#146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
firai
changed the title
codemirror-vim to 6.2.1codemirror-vim to 6.2.1 and jupyterlab to 4.2.5
firai
changed the title
codemirror-vim to 6.2.1 and jupyterlab to 4.2.5codemirror-vim to 6.2.1 and jupyterlab to 4.2.0
|
Hi @krassowski and @ianhi, can either of you help release a new version? It seems like I don't have the permissions to do so. Not sure if it's worth mentioning #138 as a known issue in the release notes. |
|
Not sure if this has to do with your permissions, it failed for me too: https://github.com/jupyterlab-contrib/jupyterlab-vim/actions/runs/10880534712 I think the token has expired, let me set it up for the trusted publishers mechanism |
|
Ok, after #147 and a few tweaks in the settings the release came through: https://github.com/jupyterlab-contrib/jupyterlab-vim/releases/tag/v4.1.4 - you should be able to update the release notes manually now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Fixes #109, amongst other bug fixes and enhancements in
codemirror-vim(replit/codemirror-vim@v6.0.14...v6.2.1).Code changes
codemirror-vimto 6.2.1.jupyterlabpackages to 4.2.0 to get updated@codemirror/viewfor Please respect Jupyterlab settings for non-blinking cursor #109.nullforcm.state.vim, introduced bycodemirror-vim(add types for vim.js replit/codemirror-vim#162).Known issues
Not introduced by this PR, but #138 is still broken. JL 4.1, which introduced the new behavior, was already required since #135, so this PR does not (by itself) make the conflict unavoidable.