Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce JupyterLab3 keyword for JupyterLab 3 #106

Closed
echarles opened this issue Oct 24, 2020 · 5 comments · Fixed by #107
Closed

Enforce JupyterLab3 keyword for JupyterLab 3 #106

echarles opened this issue Oct 24, 2020 · 5 comments · Fixed by #107

Comments

@echarles
Copy link
Member

I have read @ianhi suggesting using Trove classification https://github.com/pypa/trove-classifiers/blob/master/src/trove_classifiers/__init__.py.

As workaround, we could also enforce jupyterlab3 as keyword that would make it clear that we don't search on server side components of former jupyterlab2 extensions.

pip search jupyterlab3
quirkshop-jlab3-react (0.1.0)  - Quirkshop JupyterLab3 React
pip search jupyterlab
jupyterlab (2.2.9)                            - The JupyterLab notebook server extension.
  INSTALLED: 2.3.0a0
  LATEST:    2.2.9
jupyterlab-server (1.2.0)                     - JupyterLab Server
  INSTALLED: 1.2.0 (latest)
jupyterlab-wipp (0.3.0)                       - WIPP integratio
...
@echarles
Copy link
Member Author

cc/ @jasongrout @jtpio @goanpeca

@goanpeca
Copy link
Member

goanpeca commented Oct 24, 2020

This is a great idea!

@goanpeca
Copy link
Member

Would it make sense to have some "check" script so that documentation can include running this script (latest version available), that way we can enforce that before making a release of a new extension we check for some things, like including this keyword?

Much like check-manifest tool work, like jlab-check-extension.

@jasongrout
Copy link
Contributor

jasongrout commented Oct 24, 2020

It looks like we could clear the bar for adding a trove classifier, like Framework :: JupyterLab :: 3 and maybe Framework :: JupyterLab :: 2. Here's a recent addition, for example: pypa/trove-classifiers#53

Here is a comment about the requirements: pypa/trove-classifiers#24 (comment)

I think we could get at least 10 python packages for jlab plugins that would vouch for having a classifier.

@echarles echarles changed the title Enfoce JupyterLab3 keyword for JupyterLab 3 Enforce JupyterLab3 keyword for JupyterLab 3 Jan 4, 2021
@fcollonval
Copy link
Member

Closing this one as both the keyword and the classifier are set by this template.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants