Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gitignore files and add JupyterLab3 keyword #107

Merged
merged 1 commit into from
Nov 23, 2020

Conversation

goanpeca
Copy link
Member

@goanpeca goanpeca commented Oct 24, 2020

Related to #106

@goanpeca goanpeca changed the base branch from master to 3.0 October 24, 2020 15:57
@goanpeca goanpeca changed the title Fix/keyword Update gitignore files and add JupyterLab3 keyword Oct 24, 2020
Copy link
Member

@echarles echarles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thx @goanpeca

@jasongrout
Copy link
Contributor

Following the pattern at https://github.com/pypa/trove-classifiers/blob/master/src/trove_classifiers/__init__.py#L105, should we do "Framework :: JupyterLab :: 3", or perhaps "Framework :: Jupyter :: JupyterLab :: 3"?

@goanpeca
Copy link
Member Author

Sure why not, but what is optional and needs to exist? Or which one can we use right away?

@jasongrout
Copy link
Contributor

Good question. I don't know if we can use classifiers that aren't officially listed. More about the application process over at #106 (comment) - I think this can probably be done in parallel with a keyword (in fact, having a keyword would make it easier to find packages that would be on the application for the trove classifier)

@goanpeca
Copy link
Member Author

goanpeca commented Nov 23, 2020

@jasongrout will work on requesting the trove classifier as you suggested on #106.

This one should be good to merge anyway while the other part is done. As you rightly pointed out,

having a keyword would make it easier to find packages that would be on the application for the trove classifier

So we can merge :)

Any takers to press the green button :-p ?

@echarles echarles merged commit 1fca106 into jupyterlab:3.0 Nov 23, 2020
@echarles
Copy link
Member

Thx @goanpeca Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enforce JupyterLab3 keyword for JupyterLab 3
4 participants