Restore the use of contentHeader, make CI green, improve scripts
#263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
force us to reformat a file which would change ranges, so checking embedme first is pointless
krassowski
changed the title
contentHeadercontentHeader, make CI green, improve scripts
|
The remaining failure is unrelated: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #262
Previously implementation would simply override the main area widget altogether (as seen on the gif in README). Now it properly populates content header:
Also, fixes linting issue in
context-menuexampleAlso, actually runs embedme on
jlpm lintand changes order in whichlint:checkruns (we should first fix linting and only then worry about embedding as the former influences the latter)