Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downgrade spurious 'error' logs #1119

Merged
merged 2 commits into from
Nov 27, 2024
Merged

Downgrade spurious 'error' logs #1119

merged 2 commits into from
Nov 27, 2024

Conversation

ctcjab
Copy link
Contributor

@ctcjab ctcjab commented Nov 25, 2024 •
edited
Loading

Since it is expected that not all embeddings model providers will be loadable, it is wrong to log the case that one cannot be loaded with level 'error'.

Resolves #839.

@ctcjab ctcjab mentioned this pull request Nov 25, 2024
Closed
@krassowski krassowski added the bug Something isn't working label Nov 25, 2024
@krassowski
Copy link
Member

Thank you for seconding my case! I think either info or warning is fine here, but I think I would lean towards warning and not showing this message at all when the provider is not allowed.

@srdas
Copy link
Collaborator

srdas commented Nov 25, 2024 •
edited
Loading

Thank you for seconding my case! I think either info or warning is fine here, but I think I would lean towards warning and not showing this message at all when the provider is not allowed.

+1 to @krassowski , all changes can be made in get_em_providers() and I think this can be approved. (1) Change .info to .warning and (2) check if provider is not in blocked_providers before throwing the warning.

dlqqq
dlqqq requested changes Nov 25, 2024
View reviewed changes
Copy link
Member

@dlqqq dlqqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ctcjab Thanks for opening a PR to fix this! Just one small comment below.

@krassowski @ctcjab Does there exist authoritative documentation on whether info or warning should be used in these logs? I don't have much experience with producing/consuming logs, so you two are the experts here.

packages/jupyter-ai-magics/jupyter_ai_magics/utils.py Outdated Show resolved Hide resolved
@krassowski
Copy link
Member

(2) check if provider is not in blocked_providers before throwing the warning.

Let's address this separately as this is a more complex topic, I opened #1120 to track this

@ctcjab @jab
Downgrade spurious 'error' logs
58c46a1 
Since it is expected that not all model providers will be loadable, it
is wrong to log the case that one cannot be loaded with level 'error'.

Resolves jupyterlab#839.
@ctcjab ctcjab force-pushed the fix-spurious-error-logs branch from 53251f6 to 58c46a1 Compare November 26, 2024 22:55
@ctcjab ctcjab changed the title Change spurious 'error' log level to 'info' Downgrade spurious 'error' logs Nov 26, 2024
dlqqq
dlqqq approved these changes Nov 27, 2024
View reviewed changes
Copy link
Member

@dlqqq dlqqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ctcjab Great work, thank you!

@dlqqq dlqqq merged commit f8dc779 into jupyterlab:main Nov 27, 2024
12 checks passed
@dlqqq
Copy link
Member

dlqqq commented Nov 27, 2024

@meeseeksdev please backport to v3-dev

meeseeksmachine pushed a commit to meeseeksmachine/jupyter-ai that referenced this pull request Nov 27, 2024
@ctcjab @meeseeksmachine
Backport PR jupyterlab#1119: Downgrade spurious 'error' logs
8fb6f56
@meeseeksmachine meeseeksmachine mentioned this pull request Nov 27, 2024
Merged
dlqqq pushed a commit that referenced this pull request Nov 27, 2024
@meeseeksmachine @ctcjab
Backport PR #1119: Downgrade spurious 'error' logs (#1124)
9fd8b57 
Co-authored-by: ctcjab <[email protected]>
dlqqq added a commit that referenced this pull request Dec 26, 2024
@dlqqq @meeseeksmachine
@srdas @pre-commit-ci @alanmeeson @mcavdar @ctcjab @JanusChoi @brichet @github-actions @divyansshhh
V3: The Beginning (#1169)
899af0a 
* Backport PR #1049: Added new Anthropic Sonnet3.5 v2 models (#1050)

Co-authored-by: Sanjiv Das <[email protected]>

* Backport PR #1051: Added Developer documentation for streaming responses (#1058)

Co-authored-by: Sanjiv Das <[email protected]>

* Backport PR #1048: Implement streaming for `/fix` (#1059)

Co-authored-by: Sanjiv Das <[email protected]>

* Backport PR #1057: [pre-commit.ci] pre-commit autoupdate (#1060)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* Backport PR #1064: Added Ollama to the providers table in user docs (#1066)

Co-authored-by: Sanjiv Das <[email protected]>

* Backport PR #1056: Add examples of using Fields and EnvAuthStrategy to developer documentation (#1073)

Co-authored-by: Alan Meeson <[email protected]>

* Backport PR #1069: Merge Anthropic language model providers (#1076)

Co-authored-by: Sanjiv Das <[email protected]>

* Backport PR #1068: Allow `$` to literally denote quantities of USD in chat (#1079)

Co-authored-by: david qiu <[email protected]>

* Backport PR #1075: Fix magic commands when using non-chat providers w/ history (#1080)

Co-authored-by: Alan Meeson <[email protected]>

* Backport PR #1077: Fix `/export` by including streamed agent messages (#1081)

Co-authored-by: Mahmut CAVDAR <[email protected]>

* Backport PR #1072: Reduced padding in cell around code icons in code toolbar (#1084)

Co-authored-by: Sanjiv Das <[email protected]>

* Backport PR #1087: Improve installation documentation and clarify provider dependencies (#1091)

Co-authored-by: Sanjiv Das <[email protected]>

* Backport PR #1092: Remove retired models and add new `Haiku-3.5` model in Anthropic (#1093)

Co-authored-by: Sanjiv Das <[email protected]>

* Backport PR #1094: Continue to allow `$` symbols to delimit inline math in human messages (#1095)

Co-authored-by: david qiu <[email protected]>

* Backport PR #1097: Update `faiss-cpu` version range (#1101)

Co-authored-by: david qiu <[email protected]>

* Backport PR #1104: Fix rendering of code blocks in JupyterLab 4.3.0+ (#1105)

Co-authored-by: david qiu <[email protected]>

* Backport PR #1106: Catch error on non plaintext files in `@file` and reply gracefully in chat (#1110)

Co-authored-by: Sanjiv Das <[email protected]>

* Backport PR #1109: Bump LangChain minimum versions (#1112)

Co-authored-by: david qiu <[email protected]>

* Backport PR #1119: Downgrade spurious 'error' logs (#1124)

Co-authored-by: ctcjab <[email protected]>

* Backport PR #1127: Removes outdated OpenAI models and adds new ones (#1130)

Co-authored-by: Sanjiv Das <[email protected]>

* Backport PR #1131: [pre-commit.ci] pre-commit autoupdate (#1132)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* Backport PR #1125: Update model fields immediately on save (#1133)

Co-authored-by: david qiu <[email protected]>

* Backport PR #1139: Fix install step in CI (#1140)

Co-authored-by: david qiu <[email protected]>

* Backport PR #1129: Fix JSON serialization error in Ollama models (#1141)

Co-authored-by: Mr.W <[email protected]>

* Backport PR #1137: Update completion model fields immediately on save (#1142)

Co-authored-by: david qiu <[email protected]>

* [v3-dev] Initial migration to `jupyterlab-chat` (#1043)

* Very first version of the AI working in jupyterlab_collaborative_chat

* Allows both collaborative and regular chat to work with AI

* handle the help message in the chat too

* Autocompletion (#2)

* Fix handler methods' parameters

* Add slash commands (autocompletion) to the chat input

* Stream messages (#3)

* Allow for stream messages

* update jupyter collaborative chat dependency

* AI settings (#4)

* Add a menu option to open the AI settings

* Remove the input option from the setting widget

* pre-commit

* linting

* Homogeneize typing for optional arguments

* Fix import

* Showing that the bot is writing (answering) (#5)

* Show that the bot is writing (answering)

* Update jupyter chat dependency

* Some typing

* Update extension to jupyterlab_chat (0.6.0) (#8)

* Fix linting

* Remove try/except to import jupyterlab_chat (not optional anymore), and fix typing

* linter

* Python unit tests

* Fix typing

* lint

* Fix lint and mypy all together

* Fix web_app settings accessor

* Fix jupyter_collaboration version

Co-authored-by: david qiu <[email protected]>

* Remove unecessary try/except

* Dedicate one set of chat handlers per room (#9)

* create new set of chat handlers per room

* make YChat an instance attribute on BaseChatHandler

* revert changes to chat handlers

* pre-commit

* use room_id local var

Co-authored-by: Nicolas Brichet <[email protected]>

---------

Co-authored-by: Nicolas Brichet <[email protected]>

---------

Co-authored-by: david qiu <[email protected]>
Co-authored-by: david qiu <[email protected]>

* Backport PR #1134: Improve user messaging and documentation for Cross-Region Inference on Amazon Bedrock (#1143)

Co-authored-by: Sanjiv Das <[email protected]>

* Backport PR #1136: Add base API URL field for Ollama and OpenAI embedding models (#1149)

Co-authored-by: Sanjiv Das <[email protected]>

* [v3-dev] Remove `/export`, `/clear`, and `/fix` (#1148)

* remove /export

* remove /clear

* remove /fix

* Fix CI in `v3-dev` branch (#1154)

* fix check release by bumping to impossible version

* fix types

* Update Playwright Snapshots

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* [v3-dev] Dedicate one LangChain history object per chat (#1151)

* dedicate a separate LangChain history object per chat

* pre-commit

* fix mypy

* Backport PR #1160: Trigger update snapshots based on commenter's role (#1161)

Co-authored-by: david qiu <[email protected]>

* Backport PR #1155: Fix code output format in IPython (#1162)

Co-authored-by: Divyansh Choudhary <[email protected]>

* Backport PR #1158: Update `/generate` to not split classes & functions across cells (#1164)

Co-authored-by: Sanjiv Das <[email protected]>

* Remove v2 frontend components (#1156)

* First pass to remove the front end chat

* Remove code-toolbar by using a simplified markdown renderer in settings

* Remove chat-message-menu (should be ported in jupyter-chat)

* Remove chat handler

* Follow up 'Remove chat-message-menu (should be ported in jupyter-chat)' commit

* Clean package.json

* Remove UI tests

* Remove the generative AI menu

* Remove unused components

* run yarn dedupe

---------

Co-authored-by: David L. Qiu <[email protected]>

* Upgrade to `jupyterlab-chat>=0.7.0` (#1166)

* upgrade to jupyterlab-chat 0.7.0

* pre-commit

* upgrade to @jupyter/chat ^0.7.0 in frontend

* Remove v2 backend components (#1168)

* remove v2 llm memory, implement ReplyStream

* remove v2 websockets & REST handlers

* remove unused v2 data models

* fix slash command autocomplete

* fix unit tests

* remove unused _learned context provider

* fix mypy

* pre-commit

* fix optional k arg in YChatHistory

* bump jupyter chat to 0.7.1 to fix Python 3.9 tests

* revert accidentally breaking /learn

---------

Co-authored-by: Lumberbot (aka Jack) <[email protected]>
Co-authored-by: Sanjiv Das <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Alan Meeson <[email protected]>
Co-authored-by: Mahmut CAVDAR <[email protected]>
Co-authored-by: ctcjab <[email protected]>
Co-authored-by: Mr.W <[email protected]>
Co-authored-by: Nicolas Brichet <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Divyansh Choudhary <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlqqq dlqqq dlqqq approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error log when starting up extension
4 participants
@ctcjab @krassowski @srdas @dlqqq