Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v3-dev] Remove /export, /clear, and /fix #1148

Merged
merged 3 commits into from
Dec 10, 2024

Conversation

dlqqq
Copy link
Member

@dlqqq dlqqq commented Dec 9, 2024

Description

  • Closes [v3-dev] Update chat handlers for v3 #1145.
  • Removes /export, /clear, and /fix slash commands.
  • /export and /clear are no longer necessary, as chats are already persisted as files and users can create new chats to start fresh.
  • The /fix slash command currently doesn't work and will be superseded by a new WIP feature coming soon. We can reinstate /fix easily if the need arises.

@dlqqq dlqqq added the maintenance Change related to maintenance of the repository label Dec 9, 2024
Copy link
Collaborator

@JasonWeill JasonWeill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please remove mentions of these commands from the documentation? Example: https://jupyter-ai.readthedocs.io/en/latest/users/index.html#exporting-chat-history

@dlqqq
Copy link
Member Author

dlqqq commented Dec 10, 2024

@JasonWeill This PR is going into v3, so it won't affect any existing users until the first official release happens sometime around Feb 2025. We'll have to rewrite the entire documentation most likely. Therefore I think it makes sense to hold off on updating the docs until that date draws near.

@dlqqq
Copy link
Member Author

dlqqq commented Dec 10, 2024

Merging as this change is safe and easily revertible if necessary.

@dlqqq dlqqq merged commit a0b8e84 into jupyterlab:v3-dev Dec 10, 2024
8 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Change related to maintenance of the repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants