-
-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify markdown table generation in magic command - %ai list #1251
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -124,8 +124,8 @@ class BedrockCustomProvider(BaseProvider, ChatBedrock): | |
), | ||
] | ||
help = ( | ||
"- For Cross-Region Inference use the appropriate `Inference profile ID` (Model ID with a region prefix, e.g., `us.meta.llama3-2-11b-instruct-v1:0`). See the [inference profiles documentation](https://docs.aws.amazon.com/bedrock/latest/userguide/inference-profiles-support.html). \n" | ||
"- For custom/provisioned models, specify the model ARN (Amazon Resource Name) as the model ID. For more information, see the [Amazon Bedrock model IDs documentation](https://docs.aws.amazon.com/bedrock/latest/userguide/model-ids.html).\n\n" | ||
"<ul><li> For Cross-Region Inference use the appropriate `Inference profile ID` (Model ID with a region prefix, e.g., `us.meta.llama3-2-11b-instruct-v1:0`). See the [inference profiles documentation](https://docs.aws.amazon.com/bedrock/latest/userguide/inference-profiles-support.html).</li></ul>" | ||
"<ul><li> For custom/provisioned models, specify the model ARN (Amazon Resource Name) as the model ID. For more information, see the [Amazon Bedrock model IDs documentation](https://docs.aws.amazon.com/bedrock/latest/userguide/model-ids.html).</li></ul>" | ||
Comment on lines
+127
to
+128
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you explain the motivation behind this change? This doesn't seem related to the other changes. |
||
"The model provider must also be specified below. This is the provider of your foundation model *in lowercase*, e.g., `amazon`, `anthropic`, `cohere`, `meta`, or `mistral`." | ||
) | ||
registry = True | ||
|
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -30,6 +30,7 @@ dependencies = [ | |||||
"typing_extensions>=4.5.0", | ||||||
"click~=8.0", | ||||||
"jsonpath-ng>=1.5.3,<2", | ||||||
"py_markdown_table>=1.3.0" | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should have a version ceiling in each of our dependencies. Without a version ceiling, users may accidentally install Since upgrading a major version generally introduces breaking changes, we should prevent this by adding a version ceiling:
Suggested change
|
||||||
] | ||||||
|
||||||
[project.optional-dependencies] | ||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we return the same string in both the Markdown & text views? The text view is only seen when running
ipython
from the command line. You can see the different output by running this in your terminal:Right now, when you run
%ai list
from the command line, it is calling_ai_list_command_text()
, which produces something different. It seems weird that we have two different implementations for the same command. Can you explore showing the Markdown tables when%ai list
is called fromipython
directly?To get started, the
handle_list()
method should be changed to: