If model_provider_id or embeddings_provider_id is not associated with models, set it to None #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrii-i
force-pushed
the
bad_prodiver_or_embedding_id
branch
from
1641941 to
f8d91a7
Compare
|
We have a test file in |
|
@JasonWeill Thank you for looking into this PR. Added a test. |
andrii-i
force-pushed
the
bad_prodiver_or_embedding_id
branch
from
67acd89 to
7516d56
Compare
dlqqq
approved these changes
Nov 13, 2023
|
@meeseeksdev please backport to 1.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/jupyter-ai
that referenced
this pull request
Nov 13, 2023
…er_id is not associated with models, set it to None
andrii-i
added a commit
that referenced
this pull request
Nov 13, 2023
…ot associated with models, set it to None (#467) Co-authored-by: Andrii Ieroshenko <[email protected]>
dbelgrod
pushed a commit
to dbelgrod/jupyter-ai
that referenced
this pull request
Jun 10, 2024
… models, set it to None (jupyterlab#459) * if ids are not getting associated with models, set them to None * add test_handle_bad_provider_ids * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix tests * Add docstrings * adjust docstrings --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Marchlak
pushed a commit
to Marchlak/jupyter-ai
that referenced
this pull request
Oct 28, 2024
… models, set it to None (jupyterlab#459) * if ids are not getting associated with models, set them to None * add test_handle_bad_provider_ids * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix tests * Add docstrings * adjust docstrings --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
model_provider_idorembeddings_provider_idis not associated with available models, set it toNone.To test:
echo "$(jupyter --data-dir)/jupyter_ai/config.json"config.jsonin your data dir and changemodel_provider_idand/orembeddings_provider_idto one not provided by the serverBefore:
After:
