Message as ymap in shared document #299
Open
+366
−95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
brichet
force-pushed
the
messages_as_ymaps
branch
from
d3d3fd1 to
e050a8f
Compare
brichet
force-pushed
the
messages_as_ymaps
branch
from
22bfa8f to
061c159
Compare
|
I think this PR is ready for review. I tested it successfully with message edition from the frontend and the backend (with |
|
A follow up PR will refactor a little bit he frontend/react to avoid updating all the messages when a message is added or remove from the list. I didn't want to push these changes in this PR because it is not directly related to using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #300
This PR uses
YMapfor each message in the shared document of the chat (jupyterlab-chat), instead of a static dictionary structure.This allows individual messages to be updated without updating the entire message list.
Code change
Messageobject, implement a newIMessageinterface. This new object includes, in addition to the messages content (body,time,sender...), a signal emitting when it has been updated.The react component associated to this message only renders when the message is updated.