Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow python symlinks in environments #770

Merged
merged 1 commit into from
Feb 16, 2024
Merged

allow python symlinks in environments #770

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions src/main/registry.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,6 @@ export class Registry implements IRegistry, IDisposable {
}

// discover environments on system
// TODO: rediscover environments in app's envs directory
const pathEnvironments = this._loadPathEnvironments();
const condaEnvironments = this._loadCondaEnvironments();
const allEnvironments = [pathEnvironments, condaEnvironments];
Expand Down Expand Up @@ -284,9 +283,7 @@ export class Registry implements IRegistry, IDisposable {
sort?: boolean
): Promise<IPythonEnvironment[]> {
let filteredEnvs = envs.filter(env => this._pathExistsSync(env.path));
const uniqueEnvs = this._getUniqueObjects(filteredEnvs, env => {
return fs.realpathSync(env.path);
});
const uniqueEnvs = this._getUniqueObjects(filteredEnvs);
const resolvedEnvs = await Promise.all(
uniqueEnvs.map(async env => await this._resolveEnvironment(env.path))
);
Expand Down
Loading