-
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to hatch #217
Migrate to hatch #217
Conversation
@ktaletsk I would advice going a step further and migrate to the new extension template. It will allow to update the machinery through the template to ease maintenance. If you want I can help with that. |
] | ||
dependencies = [ | ||
"jupyter_server>=2,<3", | ||
"jupyterlab>=4,<5", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would drop the dependency on JupyterLab itself (except if you call a specific endpoint). This will allow to install this extension in Notebook v7 without installing JupyterLab as I guess this extension does not depend directly on the JupyterLab layout.
"jupyterlab>=4,<5", |
"jupyterlab_latex/labextension/**", | ||
"package-lock.json", | ||
"yarn.lock" | ||
[tool.tbump] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you switch to the new extension template, this will switch to using hatch directly aligning NPM and Python package version using: https://github.com/agoose77/hatch-nodejs-version
[tool.hatch.build.targets.wheel.shared-data] | ||
"jupyterlab_latex/labextension/static" = "share/jupyter/labextensions/@jupyterlab/latex/static" | ||
"install.json" = "share/jupyter/labextensions/@jupyterlab/latex/install.json" | ||
"jupyterlab_latex/labextension/build_log.json" = "share/jupyter/labextensions/@jupyterlab/latex/build_log.json" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should not check for this log file.
"jupyterlab_latex/labextension/build_log.json" = "share/jupyter/labextensions/@jupyterlab/latex/build_log.json" |
Closing in favor of #230 |
Migrate installation from
jupyter_packaging
tohatch
following the docs here: https://hatch-jupyter-builder.readthedocs.io/en/latest/source/how_to_guides/migrating_javascript_projects.html