Skip to content

Conversation

@andrii-i
Copy link
Contributor

@andrii-i andrii-i commented Oct 23, 2025

References

Code changes

Show more outputs button-associated CSS.

User-facing changes

Show more outputs button design. Please find preview of the current version below in this section and previews of other options I've considered in the Other options considered section.

Key changes:

  • Changed from width: 100% to adaptive width with constraints that should accommodate all potential translations.
min-width: 150px;
max-width: 220px;
  • Changed button height to match Click to add a cell. footer button / clickable region height so that it would not visually clash with and to save vertical space
  • Used primary border color instead of more subtle secondary border color for more visibility as width is decreased from 100%
Screenshot 2025-10-24 at 8 06 24 AM Screenshot 2025-10-24 at 8 06 08 AM

Kapture 2025-10-24 at 07 59 17

Other options considered

  • Width 100% as merged in Update Show more outputs button design #18021: I think visual hierarchy argument makes a lot of sense, have not considered it while working on the merged PR though. At the same time width 100% works well in terms of not clashing / aligning well with Click to add a cell. footer button / clickable region (relevant to the point below).
    300 px
  • Wider fixed width: 300 px, 400 px, and 500 px. From my POV while wider width adds clickable area, currently used width is wide enough. 300 px looks fine but from my POV 400 px and 500 px width don't aligb with visual hierarchy and clash with Click to add a cell. footer button / clickable region.
Click to see screenshots

300 px
300_and

400px
400px
400_and

500px
500pix_and

  • Width 50%, width 80%: same as fixed width 500px in terms of both clashing with visual hierarchy and visually clash with Click to add a cell. footer button / clickable region
Click to see screenshots

50%
Screenshot 2025-10-24 at 7 31 20 AM
Screenshot 2025-10-24 at 7 31 32 AM
Screenshot 2025-10-24 at 7 31 38 AM

Backwards-incompatible changes

None

@jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@github-actions github-actions bot added pkg:outputarea tag:CSS For general CSS related issues and pecadilloes Design System CSS labels Oct 23, 2025
@andrii-i andrii-i force-pushed the show_more_outputs_btn_iteration branch from 42711fd to 1f90c98 Compare October 24, 2025 15:34
@andrii-i andrii-i marked this pull request as ready for review October 24, 2025 19:40
…use minimal padding to save vertical space, use border with more contrast
@andrii-i andrii-i force-pushed the show_more_outputs_btn_iteration branch from 1f90c98 to 39e2c87 Compare October 24, 2025 19:56
@andrii-i
Copy link
Contributor Author

@krassowski opened this as a follow-up to #18021, would appreciate if you would give it a look

@krassowski
Copy link
Member

What about say 80% and having it centered? Or calc(100% - 20px)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Design System CSS enhancement pkg:outputarea tag:CSS For general CSS related issues and pecadilloes

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants