Obtain WASM/JS files from emscripten-forge #37
Conversation
Co-authored-by: Thorsten Beier <[email protected]>
|
Looks promising. Probably the package release process is broken now, but I'll deal with that at the next release. |
| "build": "tsc", | ||
| "eslint": "npm run eslint:check -- --fix", | ||
| "eslint:check": "eslint . --cache --ext .ts,.tsx", | ||
| "lint": "npm run prettier && npm run eslint", | ||
| "lint:check": "npm run prettier:check && npm run eslint:check", | ||
| "prepack": "npm install && npm run build", | ||
| "prepack": "npm install && npm run fetch:wasm && npm run build", |
There was a problem hiding this comment.
Looks promising. Probably the package release process is broken now, but I'll deal with that at the next release.
Isn't this change enough to pull the files at release time?
There was a problem hiding this comment.
Maybe we can check the files are properly included in the release artifacts built by the check_release workflow: https://github.com/jupyterlite/cockle/actions/runs/10300533031
There was a problem hiding this comment.
The change is enough for me locally so it should it should be fine for a release provided micromamba is set up properly. It looks I started but didn't finish that.
There was a problem hiding this comment.
Right, I see the prep-release.yml workflow was also updated to install micromamba, so it should hopefully work.
* Obtain WASM/JS files from emscripten-forge Co-authored-by: Thorsten Beier <[email protected]> * Update CI * Install micromamba in check-release CI * Install micromamba in prep-release CI run --------- Co-authored-by: Thorsten Beier <[email protected]>
This PR removes the WASM/JS files from this repo and instead obtains them at build time from Emscripten-forge, based on the work in #25. Co-authored by @DerThorsten.
This passes the tests locally for me and works with
cockle-playground. It currently doesn't work with the JupyterLiteterminalextension but I think that is an existing issue in JupyterLite related to the recent upgrades and I will deal with that separately.