-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix werkzeug cannot import name 'safe_str_cmp' & circular imports #30
base: master
Are you sure you want to change the base?
Conversation
- refactor to use flask bluebird to fix circular dependency issue - add .vscode to .gitignore
@@ -182,7 +182,8 @@ <h2>{{ _('About groceri.es') }}</h2> | |||
function profile() { | |||
let form = document.getElementById('profile-form') | |||
form.addEventListener('submit', function(event) { | |||
let uri = '{{ url_for('profile') }}' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was causing the settings page to error-out completely. I see that there was already an issue with the settings page, which I'm guessing is because there isn't a profile page or a profile.html template. So, I'm thinking the best path forward is to create the page or template?
@@ -73,7 +73,7 @@ <h1><i class="calendar icon"></i>{{ _("Meal planning") }}</h1> | |||
</td> | |||
<td></td> | |||
<td> | |||
<a class="ui labeled icon button" href="{{ url_for('recipes', schedule='24-3-2020') }}"> | |||
<a class="ui labeled icon button" href="{{ url_for('main.recipes', schedule='24-3-2020') }}"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
each of these changes is related to using blueprint here:
https://github.com/juriansluiman/groceri.es/pull/30/files#diff-0c2bad94cd303c5944a38a94f62a63355b8bed2e102dc87c0f44de95cf135b8aR26
Still QAing this. Doesn't look like I'm able to add a pantry section. Edit - that seems to be expected. That part looks unfinished. |
This should be good to go. I was able to create a new recipe successfully. LMK what you think, @juriansluiman. :) |
related Issues:
#29
#28
#19