Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix werkzeug cannot import name 'safe_str_cmp' & circular imports #30

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

5t33
Copy link

@5t33 5t33 commented Sep 4, 2022

  • Updated several dependencies to fix safe_str_cmp werkzeug issue
  • refactor to use flask blueprint to fix circular dependency issue
  • add .vscode to .gitignore

related Issues:
#29
#28
#19

- refactor to use flask bluebird to fix circular dependency issue
- add .vscode to .gitignore
@5t33 5t33 changed the title Fix werkzeug cannot import name 'safe_str_cmp' & circular imports (WIP) Fix werkzeug cannot import name 'safe_str_cmp' & circular imports Sep 4, 2022
@@ -182,7 +182,8 @@ <h2>{{ _('About groceri.es') }}</h2>
function profile() {
let form = document.getElementById('profile-form')
form.addEventListener('submit', function(event) {
let uri = '{{ url_for('profile') }}'
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was causing the settings page to error-out completely. I see that there was already an issue with the settings page, which I'm guessing is because there isn't a profile page or a profile.html template. So, I'm thinking the best path forward is to create the page or template?

@@ -73,7 +73,7 @@ <h1><i class="calendar icon"></i>{{ _("Meal planning") }}</h1>
</td>
<td></td>
<td>
<a class="ui labeled icon button" href="{{ url_for('recipes', schedule='24-3-2020') }}">
<a class="ui labeled icon button" href="{{ url_for('main.recipes', schedule='24-3-2020') }}">
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@5t33
Copy link
Author

5t33 commented Sep 4, 2022

Still QAing this. Doesn't look like I'm able to add a pantry section.

Edit - that seems to be expected. That part looks unfinished.

@5t33 5t33 changed the title (WIP) Fix werkzeug cannot import name 'safe_str_cmp' & circular imports Fix werkzeug cannot import name 'safe_str_cmp' & circular imports Sep 4, 2022
@5t33
Copy link
Author

5t33 commented Sep 4, 2022

This should be good to go. I was able to create a new recipe successfully. LMK what you think, @juriansluiman. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant