Skip to content

Commit

Permalink
Southern Africa no longer matches the South Africa (ZA) country (#31)
Browse files Browse the repository at this point in the history
* Southern Africa no longer matches the South Africa (ZA) country

* Add test
  • Loading branch information
mmoriniere authored May 2, 2024
1 parent 4fbab71 commit 6f4f96d
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 2 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@ All notable changes to this project will be documented in this file.

The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)

## [5.2.1] - 2024-05-02

- "Southern Africa" no longer matches South Africa.

## [5.2.0] - 2024-04-08

- Use French region names when finding French subdivisions
Expand Down
2 changes: 1 addition & 1 deletion geoconvert/__init__.py
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
__author__ = "Octopusmind <[email protected]>"
__version__ = "5.2.0"
__version__ = "5.2.1"
1 change: 0 additions & 1 deletion geoconvert/data/countries.py
Original file line number Diff line number Diff line change
Expand Up @@ -541,7 +541,6 @@
"somalia": "SO",
"south africa": "ZA",
"south georgia and the south sandwich islands": "GS",
"southern africa": "ZA",
"spain": "ES",
"sri lanka": "LK",
"sudan": "SD",
Expand Down
1 change: 1 addition & 0 deletions tests/test_countries.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ class TestCountries:
("Allemagne", {}, "DE"), # fr
("Alemanha", {}, "DE"), # pt
# If no country found, return None
("Southern Africa", {}, None),
("Wonderland", {}, None),
("Germany", {"lang": "fr"}, None),
# No confusion with Congo ("CD")
Expand Down

0 comments on commit 6f4f96d

Please sign in to comment.