Updates for new GraphicsView #630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Window sizing/positioning fixes
Fix file index misdetection due to Unicode normalization issues
CI: Update OpenSSL download link
Currently translated at 81.2% (217 of 267 strings) Translation: qView/qView Translate-URL: https://hosted.weblate.org/projects/qview/qview/nb_NO/
Currently translated at 100.0% (267 of 267 strings) Translation: qView/qView Translate-URL: https://hosted.weblate.org/projects/qview/qview/es/
Currently translated at 100.0% (267 of 267 strings) Translation: qView/qView Translate-URL: https://hosted.weblate.org/projects/qview/qview/es/
Currently translated at 100.0% (267 of 267 strings) Translation: qView/qView Translate-URL: https://hosted.weblate.org/projects/qview/qview/uk/
Currently translated at 83.1% (222 of 267 strings) Translation: qView/qView Translate-URL: https://hosted.weblate.org/projects/qview/qview/ko/
Currently translated at 100.0% (267 of 267 strings) Translation: qView/qView Translate-URL: https://hosted.weblate.org/projects/qview/qview/ko/
Fix cache using more memory than intended
Currently translated at 81.2% (217 of 267 strings) Translation: qView/qView Translate-URL: https://hosted.weblate.org/projects/qview/qview/nb_NO/
Currently translated at 100.0% (267 of 267 strings) Translation: qView/qView Translate-URL: https://hosted.weblate.org/projects/qview/qview/es/
Currently translated at 100.0% (267 of 267 strings) Translation: qView/qView Translate-URL: https://hosted.weblate.org/projects/qview/qview/es/
This occurred with "window matches image size" set to "when opening images".
Fix window getting unmaximized/resized when exiting full screen mode.
Workaround for slow font loading on Windows
Add "Reload File" feature
…s accordingly And some code deduplication.
When "window matches image size" changes, enable/disable size controls
And correct for rounding error that made the image jump around more than necessary when resizing window
To match code style of the fork in which this has a settings UI entry
The desired size already has the correct aspect ratio; any further adjustment by Qt could cause the size to be off a pixel or so from what we want.
Calculated aspect ratio was slightly off in some cases. Also enforce minimum window size in both dimensions.
…ratio is almost identical to the image's.
Not sure if this use case was intentional in qView, but regardless it exists and people have gotten used to it.
|
Oh man, sorry I left this waiting for so long. I will blindly merge this for now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For your graphicsview-rewrite branch: