Add "Delete Permanently" action (i.e. delete without trash) #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
jdpurcell
commented
Apr 30, 2024
| QString messageText; | ||
| if (permanent) | ||
| { | ||
| messageText = tr("Are you sure you want to delete %1 permanently? This can't be undone.").arg(fileName); |
There was a problem hiding this comment.
In practice I found having the adverb separated, especially if there's a longer filename filled in for the placeholder, to be a bit awkward. Could consider wording this "permanently delete %1" instead.
jurplel
reviewed
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setAlternate; Apple states A Boolean value that marks the menu item as an alternate to the previous menu item. It wasn't really hurting anything though because the previous menu item was a separator and macOS won't combine them anyway unless the assigned shortcuts differ only by the option key (I think that's how it works at least based on the testing I did).Note that this differs a bit from your request in #497 in terms of wording/shortcut keys; I had a slightly different opinion and this is a straight cherry-pick from the way I chose to do it in my fork, but feel free to request changes or make edits as necessary.