Fix regression with fullscreen titlebar text label #691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue mentioned here: #689 (comment). Specifically, the area above the viewport is now filled with the window's default background color just like it was before, to ensure the fullscreen text label is readable. The other issue mentioned in the comment is partially not really our problem, I believe it's a glitch (in Qt?) likely caused by DPI scaling, and was present before albeit hardly noticeable due to the similarity of the default window background color and the menu bar color. Nonetheless, this fix restores the original painting behavior near the top and makes the issue hardly noticeable again.