fix(locker): fix the environment variables/migrations for locker #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prasunna09
reviewed
Jan 19, 2025
| @@ -32,15 +32,15 @@ cat << EOF > locker-inner.sh | |||
| echo "Please enter the keys that are created during the locker master key generation" | |||
| echo "Enter the key1" | |||
| read -s KEY1 | |||
| curl -X 'POST' 'localhost:8080/custodian/key1' -H 'Content-Type: application/json' -d '{ "key": "'\\\\\\\$KEY1'" }' | |||
| curl -X 'POST' 'localhost:8080/custodian/key1' -H "x-tenant-id: public" -H 'Content-Type: application/json' -d '{ "key": "'\\\\\\\$KEY1'" }' | |||
There was a problem hiding this comment.
x-tenant-id will always be 'public'? or can this vary with user deployments?
There was a problem hiding this comment.
currently, depends on the environment variables. as we have set it to public.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes across multiple files to enhance the functionality and security of the locker system. The most important changes include updates to environment variables, SQL schema modifications, and adding tenant headers to API requests.
Environment variable updates:
lib/aws/card-vault/encryption.py: Updated environment variables to include new AWS KMS and secrets management configurations.SQL schema modifications:
lib/aws/migrations/locker-schema.sql: Added new tables (fingerprint,vault,entity) and modified existing tables (locker,merchant) to include additional columns and constraints.Adding tenant headers to API requests:
locker.sh: Addedx-tenant-id: publicheader to API requests for key management.unlock_locker.sh: Addedx-tenant-id: publicheader to API requests for key management.