Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: list users views in users page #1453

Merged
merged 6 commits into from
Sep 25, 2024
Merged

Conversation

Riddhiagrawal001
Copy link
Contributor

@Riddhiagrawal001 Riddhiagrawal001 commented Sep 24, 2024

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

View changes in users module
image

Motivation and Context

Closes change 1 of #1448

How did you test it?

User management page have views [My Team , Organisation , Merchant , Profile].
My team will consist of all the values for that user based on entity of the user
Organisation,Merchant & Profile will contain the users at entity organisation , merchant and profile respectively

Where to test it?

  • INTEG
  • SANDBOX
  • PROD

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@Riddhiagrawal001 Riddhiagrawal001 added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed user-management Status: issues related to user management labels Sep 24, 2024
@Riddhiagrawal001 Riddhiagrawal001 self-assigned this Sep 24, 2024
@Riddhiagrawal001 Riddhiagrawal001 requested a review from a team as a code owner September 24, 2024 08:08
Copy link

Review changes with SemanticDiff.

@Riddhiagrawal001 Riddhiagrawal001 linked an issue Sep 24, 2024 that may be closed by this pull request
@Riddhiagrawal001 Riddhiagrawal001 changed the title fix: user management views fix: list users views in users page Sep 24, 2024
Copy link
Contributor

@PritishBudhiraja PritishBudhiraja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✌️✨

Copy link
Contributor

@PritishBudhiraja PritishBudhiraja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✌️✨

@prajwalnl0 prajwalnl0 added this pull request to the merge queue Sep 25, 2024
Merged via the queue into main with commit bad2df8 Sep 25, 2024
12 checks passed
@prajwalnl0 prajwalnl0 deleted the views-for-team-management branch September 25, 2024 06:31
@github-actions github-actions bot added Closed Applied to issues or pull requests that have been successfully resolved or completed and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed user-management Status: issues related to user management labels Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Closed Applied to issues or pull requests that have been successfully resolved or completed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Views addition in List users
4 participants